Skip to content

[draft] Stats UI improvements - #186

Draft
bernhardberger wants to merge 1 commit into
TheElixZammuto:masterfrom
bernhardberger:feature/stats-and-logs-to-xaml
Draft

[draft] Stats UI improvements#186
bernhardberger wants to merge 1 commit into
TheElixZammuto:masterfrom
bernhardberger:feature/stats-and-logs-to-xaml

Conversation

@bernhardberger

@bernhardberger bernhardberger commented Apr 15, 2025

Copy link
Copy Markdown

I moved the stats into the XAML layer so it's easier to layout for readability and added a semi-transparent black backbox so stats can actually be read (this is also more in-line with what the original Moonlight project does).

This PR is a work in progress.

ToDo:

  • Move rendering of stats and logs from DX to XAML for easier access
  • fix show/hide stats after reconnect
  • maybe find a way to scroll logs
  • maybe make background transparency more accessible
  • maybe introduce a "lite" stats variant like Artemis does (I find that extremely handy for everyday use)

@coderabbitai

coderabbitai Bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@andygrundman

andygrundman commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

Note the comment in StatsRenderer::Update() about letting stats process every frame. Your change looks like it will not collect stats properly if you don't call ShouldUpdateDisplay(), that's the purpose of the boolean return value.

As I just spent a lot of time rewriting this I am not really a fan of having it all immediately removed, but I haven't yet seen what it looks like. Include some screenshots please. I also worry XAML will be harmful to the performance, for example I'm guessing it has more expensive alpha blending, but maybe you can compare the performance hit. I think XAML would be nice to ditch altogether when streaming, it's unknown yet if being in a SwapChainPanel is the source of some problems with VRR.

Not sure Logs needs any features, but one change I would make is to shorten the list of resolution text so it fits on one line:

--- a/State/MoonlightClient.cpp
+++ b/State/MoonlightClient.cpp
@@ -33,7 +33,7 @@ void logDisplayMode(const char *str, HdmiDisplayMode^ mode) {
        if (mode == nullptr) return;

        char modeStr[256];
-       snprintf(modeStr, sizeof(modeStr), "%s: %s %ux%u @ %.2fhz, %u bpp, colorspace %s, pixel encoding %s\n",
+       snprintf(modeStr, sizeof(modeStr), "%s: %s %ux%u @ %.2fhz, %u bpp, %s, %s\n",

@bernhardberger
feat: move logs and stats rendering to XAML textboxes which makes lay…
d308350 
…outing a lot more flexible and removes complexity from DX rendering
@bernhardberger
bernhardberger force-pushed the feature/stats-and-logs-to-xaml branch from d013e43 to d308350 Compare April 16, 2025 07:32
@sonarqubecloud

sonarqubecloud Bot commented Apr 16, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bernhardberger bernhardberger changed the title [WIP] Stats UI improvements [draft] Stats UI improvements Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernhardberger @andygrundman